A flag that checks if set-camera-host sexp should use the model's eyepoint for the camera position when no submodel is specified #6540
Conversation
…point for the camera position when no submodel is specificed
| @@ -502,6 +503,12 @@ void parse_mod_table(const char *filename) | |||
| } | |||
| } | |||
|
|
|||
| if (optional_string("$Use model eyepoint for set-camera-facing:")) { | |||
| stuff_boolean(&Use_model_eyepoint_for_set_camera_facing); | |||
| if (Use_model_eyepoint_for_set_camera_facing) { | |||
There was a problem hiding this comment.
There is an opening brace at the end of this line without a closing brace. An if that contains a single line doesn't need braces, but if you add them, there needs to be a pair.
| @@ -1667,6 +1675,7 @@ void mod_table_set_version_flags() | |||
| Shockwaves_damage_all_obj_types_once = true; | |||
| Framerate_independent_turning = true; // this is already true, but let's re-emphasize it | |||
| Use_host_orientation_for_set_camera_facing = true; // this is essentially a bugfix | |||
| Use_model_eyepoint_for_set_camera_facing = true; | |||
There was a problem hiding this comment.
It's good to add this flag as a bugfix, as you did here, but it's in the wrong section. Any new flags added should be associated with the upcoming stable version, so this should be added in the 25.0.0 section. (Currently, that section doesn't exist, so you'll need to create it.)
| @@ -42,6 +42,7 @@ extern bool Cutscene_camera_displays_hud; | |||
| extern bool Alternate_chaining_behavior; | |||
| extern bool Fixed_chaining_to_repeat; | |||
| extern bool Use_host_orientation_for_set_camera_facing; | |||
| extern bool Use_model_eyepoint_for_set_camera_facing; | |||
There was a problem hiding this comment.
Since the issue you are addressing is to use the model eyepoint for set-camera-host, both the variable and the text parsed in game_settings.tbl should refer to set-camera-host, not set-camera-facing.
| @@ -314,6 +314,24 @@ void camera::set_rotation_facing(vec3d *in_target, float in_rotation_time, float | |||
| matrix orient_buf; | |||
| matrix *orient = nullptr; | |||
|
|
|||
| if (Use_model_eyepoint_for_set_camera_facing) { | |||
There was a problem hiding this comment.
This is the wrong place for the change in behavior. Since the flag is supposed to modify the functionality of set-camera-host, take a look at that sexp implementation and the functions called by it.
(If you still need help after that hint, I can give more specific information.)
No description provided.